search

czaloj / bullet

Automatically exported from code.google.com/p/bullet
0 stars 0 forks source link

trivial syntax errors #123

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Before working on reducing the number of compiler warnings, it's necessary
to reduce the number of errors :)

./src/BulletSoftBody/btSoftBody.h:420: error: comma at end of enumerator list

./src/BulletSoftBody/btSoftBodyHelpers.h:42: error: comma at end of
enumerator list

Demos/BspDemo/BspLoader.h:281: error: comma at end of enumerator list

./Extras/ConvexDecomposition/cd_wavefront.h:60: error: extra ‘;’

./Extras/ConvexDecomposition/ConvexDecomposition.h:216: error: extra ‘;’

(namespaces don't need ; on the end of them like structs/classes do)

Original issue reported on code.google.com by d...@doc.ic.ac.uk on 25 Oct 2008 at 11:22

GoogleCodeExporter commented 9 years ago 
src/BulletSoftBody/btSoftBodyConcaveCollisionAlgorithm.cpp:86: error: extra 
‘;’

Extras/ConvexDecomposition/splitplane.h:57: error: extra ‘;’

Extras/ConvexDecomposition/cd_vector.h:1175: error: extra ‘;’
Extras/ConvexDecomposition/cd_vector.h:1181: error: extra ‘;’
Extras/ConvexDecomposition/cd_vector.h:1183: error: extra ‘;’

Extras/ConvexDecomposition/cd_hull.h:150: error: extra ‘;’

Extras/ConvexDecomposition/planetri.h:45: error: comma at end of enumerator list

Extras/ConvexDecomposition/splitplane.cpp:306: error: extra ‘;’

Extras/ConvexDecomposition/concavity.h:57: error: extra ‘;’
Extras/ConvexDecomposition/ConvexDecomposition.cpp:377: error: extra ‘;’

Original comment by d...@doc.ic.ac.uk on 25 Oct 2008 at 11:29

GoogleCodeExporter commented 9 years ago 
Extras/ConvexDecomposition/cd_wavefront.cpp:860: error: extra ‘;’

Extras/ConvexDecomposition/ConvexBuilder.cpp:58: error: extra ‘;’

Extras/ConvexDecomposition/cd_hull.cpp:3235: error: extra ‘;’

Extras/ConvexDecomposition/concavity.cpp:795: error: extra ‘;’

src/BulletCollision/CollisionDispatch/btCollisionDispatcher.cpp

Original comment by d...@doc.ic.ac.uk on 25 Oct 2008 at 11:36

GoogleCodeExporter commented 9 years ago 
src/BulletCollision/CollisionDispatch/btConvexConcaveCollisionAlgorithm.cpp:75:
error: extra ‘;’

Original comment by d...@doc.ic.ac.uk on 25 Oct 2008 at 11:36

GoogleCodeExporter commented 9 years ago 
src/BulletCollision/CollisionShapes/btConvexInternalShape.cpp:51: error: extra 
‘;’

src/BulletDynamics/ConstraintSolver/btContactConstraint.cpp:428: error: extra 
‘;’

Extras/ConvexDecomposition/bestfit.cpp:269: error: extra ‘;’

Extras/ConvexDecomposition/fitsphere.cpp:63: error: extra ‘;’

./Extras/COLLADA_DOM/include/dae/daeElement.h:32: error: extra ‘;’

./Extras/COLLADA_DOM/include/1.4/dom/domTypes.h:1256: error: extra ‘;’

Extras/BulletMultiThreaded/SpuSolverTask/SpuParallellSolverTask.h:98: error: 
extra ‘;’
Extras/BulletMultiThreaded/SpuParallelSolver.cpp:87: error: extra ‘;’

Extras/BulletMultiThreaded/SpuSampleTaskProcess.cpp:55: error: extra ‘;’

Extras/BulletMultiThreaded/SpuNarrowPhaseCollisionTask/SpuGjkEpa2.h:15: error: 
comma
at end of enumerator list

Extras/BulletMultiThreaded/SpuNarrowPhaseCollisionTask/SpuGjkEpa2.cpp:503: 
error:
comma at end of enumerator list

Extras/BulletMultiThreaded/SpuNarrowPhaseCollisionTask/SpuGatheringCollisionTask
.cpp:168:
error: extra ‘;’

Extras/BulletMultiThreaded/SpuSolverTask/SpuParallellSolverTask.cpp:72: error: 
extra ‘;’

Extras/ConvexDecomposition/vlookup.cpp:268: error: extra ‘;’
Extras/ConvexDecomposition/vlookup.cpp:273: error: extra ‘;’

Original comment by d...@doc.ic.ac.uk on 25 Oct 2008 at 11:56

GoogleCodeExporter commented 9 years ago 
All of the above is patched, plus a couple of warnings that were annoying me.

There should be no changes to Bullet's behaviour.

Original comment by d...@doc.ic.ac.uk on 26 Oct 2008 at 12:14

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the reports.

Can you create a patch that is relative from the Bullet root directory, so that 
it is 
compatible with tortoisesvn 'apply patch' ?

Original comment by erwin.coumans on 27 Oct 2008 at 6:55

GoogleCodeExporter commented 9 years ago 

Some of the changes has been applied. Please avoid the Extras folder for now, 
and 
focus on the core Bullet/src library.

The patch seems to be applied to an outdated version: BulletMultiThreaded has 
been 
moved to Bullet/src in the latest trunk.

Original comment by erwin.coumans on 27 Oct 2008 at 8:18

GoogleCodeExporter commented 9 years ago 
I generated the patch from the bullet-2.72 tarball

I've just started using http://bullet.googlecode.com/svn/trunk/ so future 
patches
will be suitable for that.  I'll also make them relative to the root, in fact 
I'll
probably use svn diff rather than use diff directly.  This produces relative 
diffs
and has the advantage that I don't have to go through the patch removing 
references
to files that are not part of the repository (e.g. generated files)

Assuming an up-to-date patch, why not fix syntax errors in the Extras?  At 
least the
parts that are used by the demos.  Basically what I did here was turn on the 
level of
gcc warnings that I use for my own project and just ran 'jam' in the Bullet 
root. 
There were huge numbers of warnings but these are the actual errors that the 
stricter
parser didn't understand and therefore blocked compilation.  They're all 
basically
superfluous semicolons/commas, anyway.  Not a big deal.

Original comment by d...@doc.ic.ac.uk on 27 Oct 2008 at 9:16

GoogleCodeExporter commented 9 years ago 
This patch should apply to the root and fixes the multithreaded stuff in src 
and a
couple more things in src that somehow got missed first time

Original comment by d...@doc.ic.ac.uk on 27 Oct 2008 at 9:51

Attachments:

GoogleCodeExporter commented 9 years ago 
above patch fixes these:

src/BulletCollision/CollisionDispatch/btCollisionDispatcher.cpp:60: error: 
extra ‘;’
src/BulletMultiThreaded/SpuNarrowPhaseCollisionTask/SpuGatheringCollisionTask.cp
p:160: error:
extra ‘;’
src/BulletMultiThreaded/SpuParallelSolver.cpp:87: error: extra ‘;’
src/BulletMultiThreaded/SpuSampleTaskProcess.cpp:55: error: extra ‘;’
src/BulletMultiThreaded/SpuSolverTask/SpuParallellSolverTask.cpp:72: error: 
extra ‘;’
src/BulletMultiThreaded/SpuSolverTask/SpuParallellSolverTask.h:98: error: extra 
‘;’
src/BulletSoftBody/btSoftBodyConcaveCollisionAlgorithm.cpp:86: error: extra 
‘;’

Original comment by d...@doc.ic.ac.uk on 27 Oct 2008 at 9:51

GoogleCodeExporter commented 9 years ago 
the attached patch fixes these

Extras/COLLADA_DOM/include/1.4/dom/domTypes.h:1256: error: extra ‘;’
Extras/COLLADA_DOM/include/dae/daeElement.h:32: error: extra ‘;’
Extras/ConvexDecomposition/bestfit.cpp:269: error: extra ‘;’
Extras/ConvexDecomposition/cd_hull.h:150: error: extra ‘;’
Extras/ConvexDecomposition/fitsphere.cpp:63: error: extra `;'
Extras/ConvexDecomposition/planetri.h:45: error: comma at end of enumerator list
Extras/ConvexDecomposition/splitplane.h:57: error: extra ‘;’
Extras/ConvexDecomposition/vlookup.cpp:268: error: extra ‘;’
Extras/ConvexDecomposition/vlookup.cpp:273: error: extra ‘;’

Original comment by d...@doc.ic.ac.uk on 27 Oct 2008 at 10:06

Attachments:

GoogleCodeExporter commented 9 years ago 
Here is another patch that gets rid of some warnings.  I think this covers 
everything
that was in the original patch and it's all applicable to latest svn.

src/BulletCollision/BroadphaseCollision/btDbvt.h:874: warning: unused parameter 
‘rayTo’
src/BulletCollision/BroadphaseCollision/btOverlappingPairCache.h:431: warning: 
unused
parameter ‘ghostPairCallback’
src/BulletCollision/CollisionShapes/btEmptyShape.h:59: warning: unused parameter
‘aabbMax’
src/BulletCollision/CollisionShapes/btEmptyShape.h:59: warning: unused parameter
‘aabbMin’
src/BulletCollision/CollisionShapes/btEmptyShape.h:59: warning: unused parameter
‘callback’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:80: warning: 
unused
parameter ‘aabbMax’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:80: warning: 
unused
parameter ‘aabbMin’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:81: warning: 
unused
parameter ‘aabbMax’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:81: warning: 
unused
parameter ‘aabbMin’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:85: warning: 
unused
parameter ‘aabbMax’
src/BulletCollision/CollisionShapes/btStridingMeshInterface.h:85: warning: 
unused
parameter ‘aabbMin’
src/BulletDynamics/Dynamics/btDiscreteDynamicsWorld.h:153: warning: unused 
parameter
‘numTasks’

Original comment by d...@doc.ic.ac.uk on 28 Oct 2008 at 2:09

GoogleCodeExporter commented 9 years ago 
oops forgot to attach the patch

Original comment by d...@doc.ic.ac.uk on 28 Oct 2008 at 2:09

Attachments:

GoogleCodeExporter commented 9 years ago 

Some of the Extras contains external projects, such as COLLADA-DOM and libxml. 
Changes in our local copy will be overwritten by future upgrades. So it is 
better to 
send those patches up-stream to the main repositories.

But for now, your patches have been applied.

Original comment by erwin.coumans on 28 Oct 2008 at 5:44

GoogleCodeExporter commented 9 years ago 
Thanks for the patch. Most changes have been applied
http://code.google.com/p/bullet/source/detail?r=1421

please check latest trunk.

Original comment by erwin.coumans on 28 Oct 2008 at 6:53

GoogleCodeExporter commented 9 years ago 
It looks good, thanks

all the errors are gone and the only warning that spills out of the header into 
my
own project's build is the rayTo in

src/BulletCollision/BroadphaseCollision/btDbvt.h:888

Original comment by d...@doc.ic.ac.uk on 29 Oct 2008 at 12:21