Closed r0man closed 1 year ago
Hi @czan, I hope I addressed your comments. Do you want me to squash those commits into a singe one?
Yes please!
Alright, I squashed them.
Thanks for this, @r0man! I've merged this into develop
, but I like to keep a linear history, so I rebased it onto develop
in the process.
It's a bummer that we can't easily call a clojure.test
reporting function to print the events that we capture, but what you've got in this PR is no worse than what I had already written. I don't want to hold up your change waiting for a solution to that, but if you have any ideas for that I'm very interested.
Hi @czan, thanks for merging it. Next time, I base it on the develop branch. I thought I did that. About the clojure.test reporting, I might experiment a bit more with it, and let you know when I find something.
Next time, I base it on the develop branch. I thought I did that.
You did. 😊 But I merged your other PR first, so I had to rebase this one to make it linear again.
You did everything correctly. I was just letting you know because my workflow is a bit different to the "normal" way GitHub works.
Hi @czan,
here's another PR that caputures the failing event as data and prints them later in the reporting phase.
I did the following:
Capture failing test report events during the evaluation of the postcondition as data, and print them later in the reporting step in the same way as before (I hope).
Rename the function
failure-message
tofailures
and the :messages key to :failures, since we are passing now failure data around and not just plain messages.This would enable me to report the failure messages in the Emacs mode I'm working on in a smarter way.
Wdyt?