search

czarny / brisync

Control brightness of external display on macOS and OSX automatically
MIT License
240 stars 16 forks source link

Cinema Display: app slider full brightness == 40% actual max brightness #6

Closed sejmann closed 5 years ago

sejmann commented 6 years ago

While the app does manage to control the brightness of the Apple LED Cinema Display, it only seems to control the lower end of brightness, for some reason. The mapping looks something like:

slider 0% -> 0% max actual slider 50% -> 20% max actual slider 100% -> 40% max actual

It looks like some kind of per-model multiplier might be necessary, but in browsing the source, I don't see any such mechanism or anything that stands out. Any idea what might cause this effect?

czarny commented 6 years ago

Hi, can you please test application with changes added in the cinema branch? If it would resolve the problem I will add application settings. https://github.com/czarny/Brisync/tree/cinema

sejmann commented 6 years ago

Wow, yes, that new version works perfectly. Thank you!

sejmann commented 6 years ago

Actually, I'm not sure the slider display is updated appropriately. The slider seems pegged at 100% when actual Cinema Display (actual) brightness is >= 40%, even though the actual automatic brightness syncing is working appropriately. Only a cosmetic issue, however.

czarny commented 6 years ago

It was a quick fix for test, it may work only one way for now.

czarny commented 6 years ago

Hi, I've added app preferences, let me know does this resolve all problems.