czarny / brisync

Control brightness of external display on macOS and OSX automatically
MIT License
240 stars 16 forks source link

Clamshell mode with Apple Keyboard #7

Closed rolandilles closed 5 years ago

rolandilles commented 6 years ago

Hey, first of all: nifty little app! Is there any way to make this work in clamshell mode (i.e. with the MacBook's lid closed and monitors attached) and with an Apple Keyboard's brightness keys? The external keyboard works as expected with the lid open because the app can replicate the MacBook's brightness, but once the lid is closed I can only adjust it from the menu bar, there's no reaction to the keyboard's brightness keys.

IgorMuzyka commented 5 years ago

@rale09 To achieve this it would probably be convenient to check with CGEvent's from the keyboard which corespond with the brightness up/down and trigger an update of brightness when capturing them, but consider the internal or a built-in display would probably give no brightness or 0.

czarny commented 5 years ago

Hi, I've added hotkeys. Brightness down ⇧ + ⌃ + F1 Brightness up ⇧ + ⌃ + F2 Fell free to update app https://github.com/czarny/Brisync/releases/tag/v1.2.0

IgorMuzyka commented 5 years ago

@czarny is there some actual pull request or you just metioned the shortcuts you wish to be triggering the extrnal monitor brightness?

czarny commented 5 years ago

I just created a new release https://github.com/czarny/Brisync/releases/tag/v1.2.0

maelcum commented 5 years ago

Brightness down ⇧ + ⌃ + F1 Brightness up ⇧ + ⌃ + F2

Great! Works on a MacBook Pro with the Alienware AW3418DW. It would be great to add the Info about Shift+Ctrl+F1/F2 to the GitHub-ReadMe/Frontpage.