search

czbar / ChessForge

Chess Forge application
MIT License
12 stars 2 forks source link

Logic for Bookmarks Order #117

Closed eradecka closed 1 year ago

eradecka commented 2 years ago

After some thinking, I believe that the most practical for a user will be bookmarking by order of specific variations in the Workbook and also ensuring that bookmark in further moves are under the earlier move:

For example, in the workbook below I run:

image

1) Bookmark All Options Here on 1...e5 (red above). Order of bookmarks was to follow order of variations in the Workbook but there is a small bug here. When I checked the bookmarks, the main variation 1...e5 is not 1st but 5th

image

However, when I close Chess Forge and reopen then the order is fixed

image

2) Now I run Bookmark All Options Here on 5...a6 (orange above). Again main variation bookmark is not the first (orange below)

image

And once I close Chess Forge and reopen it is fixed (orange below):

image

The best bookmark order logic however will be if further move bookmarks are "nested" within their previous moves as this will streamline the training. So in my example, 5th move bookmarks should be after 1st bookmark as those are sub variations of 1...e5. You can see my suggestion of the order in red above. This way, if the user systematically trains specific variation with its sub variations, he does not have to look for the bookmark everywhere

Also the small bug described above is applicable when you run Promote variation. After that the bookmark order is nto updated but once I close and reopen Chess Forge it is.

czbar commented 1 year ago

Superseded by #469 (the whole Workbook concept has changed since this issue was created)