search

czbiohub-sf / Rapid-QC-MS

Realtime quality control for mass spectrometry data acquisition
https://czbiohub-sf.github.io/Rapid-QC-MS
Other
13 stars 2 forks source link

Selecting the wrong combination of samples in the Intensity vs. Samples graph deletes the graph #62

Closed InventoRyAlpaca closed 1 year ago

InventoRyAlpaca commented 1 year ago

Underneath the analyte selection dropdown is a second drop down with a list of samples. Using the filters on the left auto-populates this filter. I can remove individual samples without issue, but adding the Urine sample deletes the graph. It seems like it's possible to also add samples that haven't been acquired yet, which also deletes the graph.

Once the graph has been deleted, interacting with the filter buttons on the left restores the graph (presumably by clearing the filter and returning it to a functioning state), though the graph is slightly messed up (see picture. Missing vertical axis value labels, axis name is overlapping, and the left 3 most columns can't be hovered over. Autoscale does not resolve.)

image

InventoRyAlpaca commented 1 year ago

image

Zooming in and then autoscaling does seem to restore the graphed items to the correct bounds, but does not restore the vertical axis labels.

wasimsandhu commented 1 year ago

I've noticed this bug with Plotly graphs since beginning development of MS-AutoQC and I'm not sure how to address it. Will come back to this after more pertinent issues.