czbiohub-sf / iohub

Pythonic and parallelizable I/O for N-dimensional imaging data with OME metadata
https://czbiohub-sf.github.io/iohub/
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Root path of BaseFOV #157

Open ziw-liu opened 1 year ago

ziw-liu commented 1 year ago

In #132 the BaseFOV.root returns a pathlib.Path object and __eq__ compares the paths of two FOVs to check if they are the same. This assumes that an FOV always has a single path. However in OME-TIFF and NDTIFF one FOV can be distributed in many TIFF files (usually a subset of all the TIFF files in the dataset). Edit: the same file can also contain multiple FOVs.

@JoOkuma Should we change this or is there a way around it?

ziw-liu commented 1 year ago

Also for OME-TIFF and NDTIFF it is cumbersome for the FOV objects to carry state of the index map, because parsing has to happen at the dataset (BaseFOVMapping) level.