czbiohub-sf / nf-predictorthologs

*de novo* orthologous gene predictions from bam + bed or fasta/fastq data
MIT License
4 stars 2 forks source link

Fix skip trimming and QC #83

Closed olgabot closed 3 years ago

olgabot commented 4 years ago

Uses @pranathivemuri's https://github.com/czbiohub/nf-predictorthologs/pull/78 changes as well

nf-core/predictorthologs pull request

Many thanks for contributing to nf-core/predictorthologs!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: CONTRIBUTING.md

pranathivemuri commented 3 years ago

also, there are 80 checks on each predict-orthologs run. I am not sure if pushing one after another cancels other one.

two things to do here are

  1. cancel the existing run if someone pushed
  2. Decide if we need both pull request and push to run same tests twice, seems redundant

Look into kmermaid ci.yml file and probably fix that

pranathivemuri commented 3 years ago

I will wait for the tests to pass to approve