Black formatting - Githubissues

czbiohub-sf / orpheum

Orpheum (Previously called and published under sencha) is a Python package for directly translating RNA-seq reads into coding protein sequence.

MIT License

18 stars 4 forks source link

Black formatting #67

Closed bluegenes closed 4 years ago

bluegenes commented 4 years ago

[x] reformatted all .py files with black
[x] updated CONTRIBUTING.md with black formatting instructions
[x] updated linting.yml github action to use black

Anything else that needs to go into this PR @olgabot?

pranathivemuri commented 4 years ago

I don't think it needs to be added as a requirement. if it is being added, we can add it to the requirements.txt. I don't see the usefulness of having black as one and the only requirement is a file called dev.txt.

although if we have a PR template like nf-core we could have a line where we say format with black and give the command as nf-core linting does. that might help people lint their own code.

pranathivemuri commented 4 years ago

@bluegenes what is the advantage of black over flake8 in one line please?

bluegenes commented 4 years ago

@pranathivemuri black reformats code for you, flake does not (afaik).

pranathivemuri commented 4 years ago

@olgabot could we merge this?

olgabot commented 4 years ago

@olgabot could we merge this?

Yep! Just wanted your eyes on it :)