czbiohub-sf / orpheum

Orpheum (Previously called and published under sencha) is a Python package for directly translating RNA-seq reads into coding protein sequence.
MIT License
18 stars 4 forks source link

rename jaccard to containment #95

Open pranathivemuri opened 3 years ago

pranathivemuri commented 3 years ago

From Olga on PR #93 To keep things clean, in a future PR, I'd like to rename jaccard --> containment because after talking with @bluegenes I've realized it's not truly a Jaccard score. The denominator isn't the union of all k-mers total between the read's translation frame and the database, but the number of k-mers in that translation frame. So it's technically not accurate and someone who is really nitpicky about what Jaccard means would be annoyed with the naming.

would require renaming of jaccard threshold etc flags would effect kmermaid, predict-orthologs pipelines