Phoenix/class implementation

[phoenixAja]

basic refactoring, still need to address testing for random array outputs

[review-notebook-app[bot]]

Check out this pull request on 

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

[olgabot]

Usage-wise, I think it would be simplest for users to have the __init__ take the arguments of the tie-breaking and return the named tuple of (correlation, p_value) like Spearman correlation in Scipy:

• https://docs.scipy.org/doc/scipy-0.18.1/reference/generated/scipy.stats.mstats.spearmanr.html
• https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.spearmanr.html

[olgabot]

Running this on some lemur data and it's taking 732.58s (12min) to do 4 comparisons, so ~3 min/comparisons. The vectors are of length 13,340. Is there a way to optimize this to run faster on large datasets?

[olgabot]

Hey any concerns about merging this in?

[phoenixAja]

yeah let me make some changes for this and then we can merge in