Fix dynamic label regex parsing behaviour

czerwonk / junos_exporter

Exporter for devices running JunOS to use with https://prometheus.io/

MIT License

198 stars 81 forks source link

Fix dynamic label regex parsing behaviour #176

Closed fstolba closed 2 years ago

fstolba commented 2 years ago

This is supposed to fix !163. Basically introduces additional constraints for user supplied regexes and ensures that at least the default regex is loaded in all cases.

If there's any feedback for the code it's more than welcome since I'm a go novice.

Also clarifies the README.md a bit.

czerwonk commented 2 years ago

Thanks for contributing! 🙂

qybl commented 2 years ago

Hi, I think this should warrant a release as 0.9.14 is not usable with -config.ignore-targets=true without also disabling dynamic interface labels.