search

czerwonk / junos_exporter

Exporter for devices running JunOS to use with https://prometheus.io/
MIT License
198 stars 81 forks source link

BGP: Implement dynamic labels from descriptions #249

Closed taktv6 closed 4 months ago

taktv6 commented 4 months ago

Implementing support for dynamic labels from descriptions for BGP related metrics. This implementation does not use any state. Unlike the implementation of dynamic labels for interface descriptions. Shall I adjust the implementation for interface metrics too?

czerwonk commented 4 months ago

Looks good so far. I like the new approach and would love to see it for interface metrics as well. In my opinion the naming of the interfacelabels package and its types do not fit any more. We can either rename it within this change to prevent using misleading naming in master (trade-off: more complex MR) or do the renaming prior to changing the interface description logic.

taktv6 commented 4 months ago

I'm happy to follow up today with a cleanup after we merge this.