search

czerwonk / ping_exporter

Prometheus exporter for ICMP echo requests using https://github.com/digineo/go-ping
MIT License
524 stars 115 forks source link

metrics: allow for best practices #45

Closed dmke closed 3 years ago

dmke commented 3 years ago

To quote #16:

To follow the official Prometheus guidelines, as well as comments from Prometheus developers, we should be using seconds as the unit for all ping_rtt metrics (e.g. ping_rtt_best_seconds instead of ping_rtt_best_ms).

This adds a flag --metrics.rttunit=s, to allow the user to follow those best practices.

To keep upgrading users from tripping over this change, the default units will remain millis.

Fixes: #16

czerwonk commented 3 years ago

Nice solution :)