search

czhi-bin / pe

0 stars 0 forks source link

Does not check for invalid prefix #5

Open czhi-bin opened 2 years ago

czhi-bin commented 2 years ago

When an invalid prefix is inputted, it is not handled properly

image.png

nus-pe-bot commented 2 years ago

Team's Response

The issue presented by tester is true, however it doesn't serverly impacts the use of the application but may inconvincence them. Thus, it doesn't warrant a medium or high severity and isn't part our deliverables for v1.4

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree with the issue being classified as "Not in Scope". This is a legitimate user behavior (could simply just be a typo, e.g. one extra n in n/, becoming nn/)that is not handled. The invalid prefix should be caught and be treated as an incorrect command, and should not be treated as input for the previous prefix.

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Although I do agree that this should not be a severity.High, but I think it should not be severity.Low.

This flaw does affect normal operations and I think it will occur occasionally as it is quite common to have a typo. if the user tries to type a valid command but just added an extra alphabet, this will be treated as input to the previous prefix. The error message will show an error message that is supposed to be for invalid input for the previous prefix. The user might take some time to even figure out what is wrong with the inputs before he/she can realize that the error message is faulty and does not point to the actual problem.

Therefore, I think this fits the description of severity.Medium better.

image.png