czhiruo / pe

0 stars 0 forks source link

Does not make sense to be able to add only guest with different names #2

Open czhiruo opened 9 months ago

czhiruo commented 9 months ago

if i were planning my wedding and i have a wide social circle, there might be friends who have the same common first and last name which in this case i used "Justin Tan" and the only way i can differentiate them would be with the other fields.

Screenshot 2023-11-17 at 4.37.14 PM.png

nus-se-bot commented 9 months ago

Team's Response

Both are about allowing multiple guests to have the same name.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[guest add] Uniqueness of a guest

Description

It is mentioned that guests cannot share the same name as another guest.

image.png

I believe this is not a good way of distinguishing guests. It is very possible for us to have friends with the same name, and possibly even surnames. It would then not be possible for me to add all these friends.

Perhaps a better way of uniquely identifying guests would be a unique phone number, but the group has allowed same phone number for multiple guests, which does not apply in a real-world scenario.

Elaboration of labels

Feature flaw because the application hinders my ability to track guests.

Severity is low, because the chances of having such friends is low, but definitely non-zero. Especially in Singapore where some names are so common. eg. Tan Jun Jie, Gabriel Tan, etc.


[original: nus-cs2103-AY2324S1/pe-interim#4499] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rejected as:

  1. Not that common for friends to have the exact same full name
  2. Even if user has friends with exact same full name, they can easily handle this issue by adding a nickname / other identifier to the name field (e.g. "Gabriel Tan Jun Jie JC" and "Gabriel Tan Jun Jie High Sch").
  3. We believe it is more useful most of the time to prevent duplicate names so that users do not have to do duplicate detection themselves every time they want to add a guest.

Phone number comment not considered in this response as it is a suggestion and not a bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This bug should not be rejected as it is indeed a possible valid issue that users would face. Firstly, the average number of guests in a wedding is around 100 pax from a quick google search and with Singapore having such a small population, it is common to have friends with the same first and last name, excluding their given mother tongue name as most people would not know this information. As such, this issue should be considered as a valid feature flaw
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]