czhiruo / pe

0 stars 0 forks source link

Repetitive diagrams in the DG #8

Open czhiruo opened 9 months ago

czhiruo commented 9 months ago

Similar sequence diagrams to show the execution of the delete command is used in the logic component which makes the DG repetitive and cluttered Screenshot 2023-11-17 at 5.22.52 PM.png

Screenshot 2023-11-17 at 5.22.52 PM.png

Likewise the similar diagrams are shown again in the model component and the implementaiton of tracking of guests and vendors

Screenshot 2023-11-17 at 5.26.53 PM.png Screenshot 2023-11-17 at 5.26.42 PM.png

nus-pe-script commented 9 months ago

Team's Response

Our team feels the repetition is not an issue as:

  1. The diagrams are in different sections of the DG that aim to explain different things
  2. We do not expect the readers to read the DG from start-to-end, so we try to provide them the information where it is needed.

Two sequence diagrams:

Two class diagrams:

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]