czim / file-handling

File Handling Helper
MIT License
14 stars 9 forks source link

Throwing code 0 regardless of the actual code thrown #16

Closed kimchirichie closed 1 year ago

kimchirichie commented 1 year ago

https://github.com/czim/file-handling/blob/4f30d25bc832e907d36127772a8d8a250659611f/src/Storage/File/StorableFileFactory.php#L173

had a mistyped ->getcode() which already being caught inside a multiple try/catch handlers ends up throwing code 0 regardless of the actual code thrown. This is and has been part of their package for a long time and has gone unnoticed. This code 0 is then treated much like a generic 500, which is not desirable.

kimchirichie commented 1 year ago

duplicate of #15