search

czim / laravel-repository

Repository pattern implementation for Laravel
MIT License
51 stars 19 forks source link

Update some dependencies and support PHP8 #17

Closed Tjoosten closed 3 years ago

Tjoosten commented 3 years ago

Updated some package dependencies for Support Laravel 8. Also i bumped the supported php version and added php 8.

Because following the following page. (https://www.php.net/supported-versions.php) php 7.2 is not actively maintained anymore

czim commented 3 years ago

Thanks for your work. I agree with the version bump, but not with increasing the minimum required version. Though it is not recommended to use older Laravel & PHP versions, this package still works with them. I'll make the changes, but keep the lower limit as it currently is.

If you can make the php requirement ^7.2|^8.0 and the illuminate requirements ^6|^7|^8, that'd be great.

Tjoosten commented 3 years ago

Hey Czim,

Thanks for your response. I will make the changes somewhere next week. Ill keep you posted

Tjoosten commented 3 years ago

hey @czim

I lowered the version bump. Can u review and tell me if something more is needed.

czim commented 3 years ago

Looks great, thanks a lot!