czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 25 forks source link

Decouple Google ML Kit from codebase #2

Open czlucius opened 3 years ago

czlucius commented 3 years ago

Code, ScanningWrapper, and many other classes have been coupled to Google's ML Kit in one way or another (using Barcode, or ML Kit's type constants).

One suggestion is to use a Translator to "translate" the data from an abstract source(zxing, Google/Huawei ML Kit, etc.) into a general format in Code (e.g. Code's constructor accepting Barcodes will be replaced by a Translator which helps to convert them into a Code.) to decouple Google ML Kit from the codebase.