search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

[Bug]: Android CI will crash due to undeclared variables (in .gitignore) #35

Open czlucius opened 2 years ago

czlucius commented 2 years ago

As some variables aren't pushed up, Android CI will fail (for future commits)

PaT0191 commented 1 year ago

Hello, I would like to work on this issue, can you assign this to me?

czlucius commented 1 year ago

Sorry for the delay in response. Do you have a plan on how you're going to approach this? There are some API secrets that are definitely not going to be pushed up, and this causes compilation to fail for the play build flavor. Apart from that there may be other issues. Do let me know, and you can create a PR if you want as well. @PaT0191

PaT0191 commented 1 year ago

Hi, no problem. Hmmm, i can try to fix it anyway and if i wouldnt be able to fix it, i can work on this one: https://github.com/czlucius/code-scanner/issues/11

czlucius commented 1 year ago

Can you make a PR first or tell me what you intend to do?

PaT0191 commented 1 year ago

Using new MaterialAlertDialogBuilder.Builder(context) instead of new MaterialAlertDialogBuilder(context) in AddWifiAction.java:69, cant be the problem?

czlucius commented 1 year ago

The problem is not solely caused by that (although it is, as you correctly pointed out, an error) The main problem as addressed in the title is because the play variant uses a secret key that cannot be pushed up but is required for compilation.

Due to low usage, I'm thinking of removing ads. Could you help to remove advertising (AdStrategy2) in all variants? Thanks

czlucius commented 1 year ago

Using new MaterialAlertDialogBuilder.Builder(context) instead of new MaterialAlertDialogBuilder(context) in AddWifiAction.java:69, cant be the problem?

Thanks for spotting that bug. It was committed recently in a PR.

czlucius commented 1 year ago

If you'd like, can you submit a PR removing AdStrategy2 and fixing the MaterialAlertDialogBuilder code? (and test if it can build locally on your machine) Can remove strings and string references to idappad and idbannerad It would be much appreciated.

After you open a PR, I will assign this to you.

Thanks and happy hacking/contributing! 🎃

PaT0191 commented 1 year ago

The problem is not solely caused by that (although it is, as you correctly pointed out, an error) The main problem as addressed in the title is because the play variant uses a secret key that cannot be pushed up but is required for compilation.

Due to low usage, I'm thinking of removing ads. Could you help to remove advertising (AdStrategy2) in all variants? Thanks

Yeap, i can help you with that.

Thanks for spotting that bug. It was committed recently in a PR.

If you'd like, can you submit a PR removing AdStrategy2 and fixing the MaterialAlertDialogBuilder code? (and test if it can build locally on your machine) Can remove strings and string references to idappad and idbannerad It would be much appreciated.

After you open a PR, I will assign this to you.

Thanks and happy hacking/contributing! 🎃

Ill get on computer tomorow soo, then ill create PR for that. Thank you.