search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

Dark mode for OSS Licenses Webview #49

Open czlucius opened 2 years ago

czlucius commented 2 years ago

https://joebirch.co/android/enabling-dark-theme-in-android-webviews/

gauravkhuperkar commented 1 year ago

IntroActivity(On boarding screen displayed for first time after installing an app) also need support for dark mode.

czlucius commented 1 year ago

There is no IntroActivity

czlucius commented 1 year ago

I think you were referring to the Android 12 splash screen? That's a built in feature of Android.

gauravkhuperkar commented 1 year ago

Hi @czlucius thanks for quick response. Please find the attched the video of screen -

https://user-images.githubusercontent.com/15320190/198999118-66b27475-09fa-4305-bfd0-c8dd106a1c39.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com/czlucius/code-scanner/pull/55 Thank you

czlucius commented 1 year ago

Hi @czlucius thanks for quick response. Please find the attched the video of screen - whilte_onbaording_screen_in_dark_mode.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com//pull/55 Thank you

I see. I must have missed out the onboarding screen (CSOnboarding). I use a library for this, do you want to go work on it?

hhugoac commented 1 year ago

Is this issue still open I want to collaborate?

czlucius commented 1 year ago

Sure Can you take a look at the PR?

czlucius commented 1 year ago

https://github.com/czlucius/code-scanner/pull/55