search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

Wi-Fi suggestion: ask for permission solved #52

Closed KeshavAnandBhagat closed 1 year ago

KeshavAnandBhagat commented 1 year ago

Respected, czlucius

As you have said about the intent, but their is no intent for our needs, so, it is nearly impossible to do that for now at least. But we can ask users to give permission in a convenient way so that it becomes user friendly. Otherwise, we can also redirect users to wifi settings to add the network manually with wifi credential/password copied so that users can conveniently connect to the wifi network. I have implemented that in this PR. I have also attached the screenshots.

Surly, it is the Best Solution for User Convenience.

Please Accept this Request under HACKTOBERFEST-ACCEPTED to get me into this open-source world. Regards, Keshav Anand Bhagat

czlucius commented 1 year ago

Hi I noticed you used Settings.ACTION_WIFI_SETTINGS Can you try other intents and see if they lead to the WiFi control screen? I believe I saw one such intent before. And also, can you change AlertDialog.Builder to MaterialAlertDialogBuilder? That's being used throughout the project.

czlucius commented 1 year ago

Also, for the strings for the alert dialog buttons, can you add them to strings.xml? Thanks

KeshavAnandBhagat commented 1 year ago

ok I will do it as soon as possible Thanks

KeshavAnandBhagat commented 1 year ago

Respected, czlucius

As you have said for MaterialAlertDialogBuilder, I did that and also added strings for the alert dialog buttons into strings.xml I have also attached the screenshots of my work. I have tried all the intent but no one worked for our purpose.

I am glad to be working on this project, and I will continue to contribute to it. Please accept this request under HACKTOBERFEST-ACCEPTED to get me into this open-source world.

Kindly help me to qualify for HACKTOBERFEST 2022

Regards, Keshav Anand Bhagat

czlucius commented 1 year ago

Looks good. Thanks!

KeshavAnandBhagat commented 1 year ago

Respected, czlucius Thanks for accepting this PR/Merge.😀 I am glad to be working on this project, and I will continue to contribute to it.

Sir, could you please add the label HACKTOBERFEST-ACCEPTED to this PR ? I will be grateful to you.

Regards, Keshav Anand Bhagat

czlucius commented 1 year ago

Ok, I will add the label. However, as per Hacktoberfest's website, a merge is already enough to get it accepted. Happy contributing!