search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

Removed Ads, deleting some references and fixed the bug (MaterialAlertDialogBuilder) #54

Closed PaT0191 closed 1 year ago

czlucius commented 1 year ago

Can help to remove the files needed as well, and the dependency too? Thanks

czlucius commented 1 year ago

You can just delete the lines of code, no need to comment out. But good job! Thanks

PaT0191 commented 1 year ago

You can just delete the lines of code, no need to comment out. But good job! Thanks

Yeah, but maybe you will return ads in future sooo, you can easily delete the comments.

czlucius commented 1 year ago

Can help to remove the files needed as well, and the dependency too? Thanks

Can help to do this as well? Thanks

PaT0191 commented 1 year ago

Can help to remove the files needed as well, and the dependency too? Thanks

Can help to do this as well? Thanks

Oh sorry, i didnt notice that. Yeah ofc i can help. Ill try to find some free time to do it.

czlucius commented 1 year ago

Do you need this merged soon? By the way, are you participating in Hacktoberfest?

PaT0191 commented 1 year ago

Do you need this merged soon? By the way, are you participating in Hacktoberfest?

Nope, iam not participant of hacktoberfest. Just student of university who works and try to help in anyway at the same time :D.

PaT0191 commented 1 year ago

Idk if i done right what you want, but you can look at it.

czlucius commented 1 year ago

The errors are finally fixed, whatever failed action is left is just due to missing translations (which I have to go fix in Weblate - you can contribute a language if you want too). Thanks for contributing!

PaT0191 commented 1 year ago

I can try to fix issue #11 if i can.

czlucius commented 1 year ago

Ok, I will assign you to that