search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

Issue 49: Add Dark mode support for OSS Licenses Webview. #55

Open gauravkhuperkar opened 1 year ago

gauravkhuperkar commented 1 year ago

This PR introduces dark mode support for Open source license dialog.

Code changes: Using WebSettingsCompat.setForceDark (deprecated) for backward compatibility as this app has minimum sdk support as 23. It can be removed once minimum target is set to 29.

Changes are tested with android 10/11 emulator and android 11 physical device. Please find attached testing video. Video quality was reduced because off size limitations.

https://user-images.githubusercontent.com/15320190/198994842-e60eaf37-9ddc-4d01-915a-b9fa5541c958.mov

czlucius commented 1 year ago

Hi there! Thanks for contributing this patch, your work is much appreciated.