search

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)
GNU Affero General Public License v3.0
39 stars 24 forks source link

The dark mode in the OnBoardingActivity does not show the dark colors #60

Closed hhugoac closed 10 months ago

hhugoac commented 1 year ago

Steps to reproduce

  1. Open the app
  2. After open the first time, when the system is in dark mode enable, it shows

https://github.com/czlucius/code-scanner/assets/40183850/0e391bee-2f88-4d18-84f8-918a699092b4

Expected behaviour

The behavior expected is to change into dark mode

Actual behaviour

The actual Behavior is showed in the video

Device name

Pixel 3a

Android version/API Level

Android 13

App version

1.9

Device/crash logs

No response

Additional information

No response

czlucius commented 1 year ago

This looks good. 👍 Thanks for the contribution!

lalit-patel commented 10 months ago

is it still open for contribution??

czlucius commented 10 months ago

Sure! Feel free to contribute. If you need any help feel free to ask You can make a PR when you're ready with your changes

lalit-patel commented 10 months ago

I have PR the above issue , kindly check it.

czlucius commented 10 months ago

Sorry! Was attending an event the past week, was very busy. I'll check back on the PR Thanks for your contributions!

czlucius commented 10 months ago

@lalit-patel I accepted your changes