Open shendew opened 10 months ago
Added
@shendew are you sure this is not because of mismatching package names?
The debug version has a package name of com.czlucius.scan.debug
, but the content provider has a name of com.czlucius.scan.provider
without the .debug
.
I think this just happens on debug builds
@shendew are you sure this is not because of mismatching package names? The debug version has a package name of
com.czlucius.scan.debug
, but the content provider has a name ofcom.czlucius.scan.provider
without the.debug
. I think this just happens on debug buildsYes It could be, But my code part will work both situations without crash.
@shendew maybe you want to rewrite your PR, such that it uses the content provider instead, but with the app's package name prefixed instead of hardcoded? Both in that file and in the manifest.
I see your patch uses the MediaStore API if an exception is raised. Can you use IllegalArgumentException instead? And can you move strings to strings.xml? Also what's the "mmmm" about?
Additionally, can you remove the extra subject and title? I think it's better to have a consistent experience, and also if it's added it would have to be translated across the many languages my app supports. Alternatively you may want to also translate them and retrieve them from strings resources.
Thanks!
Used mediastore to get the file path. Add Extra subject and createrchooser msg to give a idea to user.