Share and Save button appears when no code is created - Githubissues

czlucius / code-scanner

An Android app to scan and generate codes(barcodes/QR codes)

GNU Affero General Public License v3.0

39 stars 25 forks source link

Share and Save button appears when no code is created #9

Closed czlucius closed 3 years ago

czlucius commented 3 years ago

The Share and Save buttons appear even when no code is created, after "OK" is pressed in the dialog

How to reproduce:

Open the app.
Go to "Create"
Press "Contents"
Press "OK" without entering anything

Expected result:

Share and Save buttons are hidden Actual result:
Share and Save buttons are still visible, and pressing them results in a crash

Fix:

Adding a simple isEmpty check in regenerateQRImage in CreateFragment solves the issue, as when "OK" is pressed, an empty(but non-null) QR is created.

Screenshot: