search

cznethub / dsp

CZNet Hub Data Submission Portal
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Verify correct registration of published datasets #100

Closed horsburgh closed 9 months ago

horsburgh commented 1 year ago

Describe the feature you'd like and what it will do A clear and concise description of what you want to happen.

If a user attempts to register a dataset that has already been published in HydroShare, EarthChem, or Zenodo, the DSP should register that dataset as is.

Why is this feature important? A short description of the importance of this feature and what it will help you achieve.

Need to ensure that the DSP does not fail upon registering a published dataset from HydroShare, EarthChem, or Zenodo that does not meet the DSP's minimum metadata validation requirements.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].

Additional context Add any other context or screenshots about the feature request here.

horsburgh commented 1 year ago

@Maurier - this issue has been closed, but I don't think it should be.

First, when I register a resource that is published in HydroShare, I am taken to the Edit page, where I can edit the resource. This is how I found the issue with the DSP allowing me to edit protected information for a published resource. I think when a published resource is registered, we should ingest the metadata "as-is". It's OK to take the user to the "Edit Submission" page, but I think you should put a message on that page that says:

This resource is published and is not editable in the Data Submission Portal. If you need to modify this resource, navigate to the resource in the repository where it is hosted and modify it there (if possible). You can refresh the metadata for this resource by clicking the "Update Record" button on the My Submissions page.

This message should appear on the Edit Submission page for any resource that is published. AND, the "Save Changes" button on the Edit Submission page should remain disabled.

Second, when I registered the published resource with the DSP it did not have the "CZNet" keyword. After registering it, that keyword was added to the resource by DSP. That's inconsistent with the resource being registered "as-is".

horsburgh commented 1 year ago

@Maurier - this issue was tagged to milestone 1.2, but since I reopened it, I'm moving it to the 1.3 milestone.