tgulacsi
commented
10 years ago I don't know whether the real issue is in lldb, or in the usage (camlistore), but this skips the panic:
diff --git a/third_party/github.com/cznic/exp/lldb/falloc.go b/third_party/github.com/cznic/exp/lldb/falloc.go
index 103a469..01c13b8 100644
--- a/third_party/github.com/cznic/exp/lldb/falloc.go
+++ b/third_party/github.com/cznic/exp/lldb/falloc.go
@@ -377,7 +377,10 @@ func (a *Allocator) cadd(b []byte, h int64) {
}
// cache full
- delete(a.m, a.cache.put(a.lru.removeBack()).h)
+ tbd := a.cache.put(a.lru.removeBack())
+ if tbd != nil {
+ delete(a.m, tbd.h)
+ }
n := a.cache.get(len(b))
n.h = h
copy(n.b, b)
@@ -1831,6 +1834,9 @@ func (c *cache) size() (sz int64) {
}
func (c *cache) put(n *node) *node {
+ if n == nil {
+ return n
+ }
s := *c
n.b = n.b[:cap(n.b)]
lenb := len(n.b)
@@ -1848,6 +1854,9 @@ type lst struct {
}
func (l *lst) pushFront(n *node) *node {
+ if n == nil {
+ return n
+ }
if l.front == nil {
l.front, l.back, n.prev, n.next = n, n, nil, nil
return n
@@ -1858,6 +1867,9 @@ func (l *lst) pushFront(n *node) *node {
}
func (l *lst) remove(n *node) *node {
+ if n == nil {
+ return n
+ }
if n.prev == nil {
l.front = n.next
} else { 
cznic
mpl
bradfitz
Hi, I'm testing camlistore, and after some camput-ting, it panics:
2013/09/20 15:58:48 http: panic serving 127.0.0.1:35186: runtime error: invalid memory address or nil pointer dereference goroutine 1718 [running]: net/http.func·007() /usr/lib/go/src/pkg/net/http/server.go:1022 +0xac camlistore.org/pkg/blobserver/diskpacked.func·001() /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/pkg/blobserver/diskpacked/diskpacked.go:339 +0xd7 camlistore.org/third_party/github.com/cznic/exp/lldb.(_lst).remove() /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/falloc.go:1861 +0xa camlistore.org/third_party/github.com/cznic/exp/lldb.(_lst).removeBack(0xc200163ab8, 0x1c) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/falloc.go:1876 +0x2e camlistore.org/third_party/github.com/cznic/exp/lldb.(_Allocator).cadd(0xc2001639a0, 0xc2002c3e7b, 0x22, 0x22, 0x53, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/falloc.go:380 +0x10e camlistore.org/third_party/github.com/cznic/exp/lldb.(_Allocator).Alloc(0xc2001639a0, 0xc2002c3e7b, 0x22, 0x22, 0x53, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/falloc.go:420 +0x1f6 camlistore.org/third_party/github.com/cznic/exp/lldb.btreeDataPage.setContent(0xc200bf90cd, 0x2f8, 0x20151, 0xc200282bc0, 0xc2001639a0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:1272 +0x50a camlistore.org/third_party/github.com/cznic/exp/lldb.btreeDataPage.setKey(0xc200bf9000, 0x3c5, 0x2021e, 0xc200282bc0, 0xc2001639a0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:1308 +0xa9 camlistore.org/third_party/github.com/cznic/exp/lldb.btreeDataPage.insertItem(0xc200bf9000, 0x3c5, 0x2021e, 0xc200282bc0, 0xc2001639a0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:1350 +0x1aa camlistore.org/third_party/github.com/cznic/exp/lldb.btree.put2(0x1, 0xc200f04000, 0x1010f, 0x2021e, 0xc200282bc0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:1888 +0xecf camlistore.org/third_party/github.com/cznic/exp/lldb.btree.put(0x1, 0xc200f04000, 0x1010f, 0x2021e, 0xc200282bc0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:1784 +0x122 camlistore.org/third_party/github.com/cznic/exp/lldb.(_BTree).Set(0xc2001c4000, 0xc2002c3e70, 0x2d, 0x2d, 0xc200776140, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/exp/lldb/btree.go:429 +0x1ca camlistore.org/third_party/github.com/cznic/kv.(_DB).Set(0xc200176a50, 0xc2002c3e70, 0x2d, 0x2d, 0xc200776140, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/third_party/github.com/cznic/kv/kv.go:756 +0xcb camlistore.org/pkg/index/kvfile.(_kvis).Set(0xc20011f790, 0xc2002c3e40, 0x2d, 0xc200776120, 0x11, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/pkg/index/kvfile/kvfile.go:84 +0xc3 camlistore.org/pkg/blobserver/diskpacked.(_storage).finishAppend(0xc200181510, 0xc200231940, 0xc2007763c0, 0x12523, 0x12523, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/pkg/blobserver/diskpacked/diskpacked.go:342 +0x28e camlistore.org/pkg/blobserver/diskpacked.(_storage).append(0xc2001566c0, 0xc200231940, 0xc2007763c0, 0x12523, 0xc20056b5a0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/pkg/blobserver/diskpacked/diskpacked.go:385 +0x5d2 camlistore.org/pkg/blobserver/diskpacked.(_storage).ReceiveBlob(0xc2001566c0, 0xc200231940, 0xc2007763c0, 0xc20056bbd0, 0xc2003c57e0, ...) /home/tgulacsi/src/camlistore.org/tmp/build-gopath/src/camlistore.org/pkg/blobserver/diskpacked/diskpacked.go:293 +0x1a0
It seems that l.back is nil. Any ideas?