[ZCO-225] Doesn't work with non-MD notes

czottmann / obsidian-mononote

An Obsidian plugin that ensures each note occupies only one tab. If a note is already open, its existing tab will be focussed instead of opening the same file in the current tab.

https://obsidian.md/plugins?id=zottmann

MIT License

89 stars 2 forks source link

[ZCO-225] Doesn't work with non-MD notes #2

Closed saif-ellafi closed 8 months ago

saif-ellafi commented 11 months ago

Any none markdown note will not work :(

Canvas notes will re-open duplicates.
Image notes (PNG, JPG, etc)
PDF notes
Same for Excalidraw Drawing notes (plugin)

Would it be possible to not de-dup on those kind of notes?

Thank you for creating this

_ZCO-225

_ZCO-345

czottmann commented 11 months ago

Hi @saif-ellafi, I'll look into this but it might be impossible — every time a Markdown file is opened (unless it's pinned, see #1), a notification is sent out to plugins by Obsidian, and this is what Mononote works with. Mononote does not check for file type at all so my suspicion is that there is no such notification for non-MD files.

I'll look into this. Might take a while, though!

czottmann commented 8 months ago

I'm currently working on this.

czottmann commented 8 months ago

@saif-ellafi Quick update: I've implemented the requested feature. I had to jumpt through several hoops to make it work because Obsidian doesn't report opening non-MD files to the plugins. 😅 I think I found a good solution for that, though.

The new feature will be rolled out in v1.1.0, due soon!

saif-ellafi commented 8 months ago

brilliant, thanks!