[ZCO-257] Prevent closing pinned tabs

[d9k]

Sometimes it's required to work with several copies of one tab (different scroll positions).

Legend:

• A: tab
• >A: selected tab
• [A]: pinned tab
• >[A]: selected pinned tab

Steps to reproduce:

0) Imagine we have Obsidian splitted by two halves. With tabs:

• I. A, >B; II. C, >D 1) Open new tab N in right Obsidian half:
• I. A, >B ; II. C, D, >N 2) Pin this tab to prevent close:
• I. A, >B; II. C, D, >[N] 3) Run "split down" or "split right" command. Now Obsidian is splitted by three parts. We have two copies of A:
• I. A, >B; II. C, D, >[N], III. >N 4) Pin tab copy to prevent close
• I. A, >B; II. C, D, >[N], III. >[N] 5) Don't want to have Obsidian splitted by three parts. Two parts are enough. So move tab copy (3rd) to left Obsidian half. Now we have two tabs:
• I. A, B, >[N]; II. C, D, >[N] 6) Now we have to work with tab B. Let's switch to it:
• I. A, >B, [N]; II. C, D, >[N] 7) Now we finished to work with tab B. We want to work again with two copies of tab N. So we switch back to tab [N] in left Obsidian half. And it disappears! 😠
  • Expected:
    • I. A, B, >[N]; II. C, D, >[N]
  • Actual: I. A, B, >[N]; II. C, D, >[N]
    • I. A, >B; II. C, D, >[N]

Please just DON'T CLOSE PINNED TABS. If we have any number of pinned tabs they must be preserved. Close not pinned tabs only!!

_ZCO-257

[d9k]

Added pull request #5

[d9k]

My fix adds new problem:

• 8. Select B on left Obsidian half again:
  • I. A, >B, [N]; II. C, D, >[N]
• 9. Just click on Obsidian right half: suddenly [N] becomes selected on left half!
  • Expected:
  • I. A, >B, [N]; II. C, D, >[N]
  • Actual:
  • I. A, B, >[N]; II. C, D, >[N]

Closing my MR for now.

[d9k]

fixed PR

[czottmann]

Hi @d9k, thanks for the report and the detailed test case and everything! Nice work. I'll have to look into this, and I will, just not right away, as Mononote is not my highest priority at the moment.

[d9k]

Quick Switcher++ plugin mostly solves duplicate tab problem (duplicate from switcher, not from following cross-notes links). Moved to this plugin for now

[czottmann]

Pull request accepted, ran into smaller issues when trying to merge, ended up copying your one-liner into the new work branch manually. Commit message contains attribution. Thanks again, @d9k!

Fix will be in the upcoming v1.1.

[czottmann]

Fixed in https://github.com/czottmann/obsidian-mononote/commit/9c14deb2de93a1b8cf23d9b9bb6bef1625acef4c