search

czue / celery-progress

Drop in, configurable, dependency-free progress bars for your Django/Celery applications.
MIT License
473 stars 90 forks source link

The progress bar does not auto-update when the network error occured and then restored #77

Open shining2007 opened 3 years ago

shining2007 commented 3 years ago

It seems the progress bar will not update anymore when it encountered a network Error. For example, when I flap the network, the progress bar will stop updating forever. I also tried to install celery-progress[websockets,redis] instead of celery-progress, but it still does not work. Do you have any good idea to make the progress bar auto-update when the network is restored?

OmarWKH commented 3 years ago

See related issue https://github.com/czue/celery-progress/issues/13 for a way to approach this.

I imagine this could be done in multiple ways:

  1. Retry continuously with a cool down interval.
  2. Retry a few times then give up.
  3. Show a button/link for the user to initiate a retry.

I don't know if any of these should be the default behaviour or not.

czue commented 3 years ago

No strong feelings about the default, but I do think that all of these options would be better than the current behavior. Options 1 and/or 2 have the benefit of not needing to introduce any new UI components so I guess I'd advocate for one of those.