czue / django-wedding-website

A django-powered wedding website and guest-management system
Other
458 stars 273 forks source link

Settings Variables Not Affecting all Pages #24

Closed dillwishlist closed 3 years ago

dillwishlist commented 5 years ago

Where are the declarations for the variables used in the email templates, etc. supposed to be defined? I presume you stripped them out for privacy reasons, where should I place them?

Such as: {{ support_email }} {{ couple }} {{ site_url }} {{ rsvp_address }}

Thanks, Alexander

czue commented 5 years ago

I think you're looking for these settings, yeah?

https://github.com/czue/django-wedding-website/blob/master/bigday/settings.py#L129-L142

dillwishlist commented 5 years ago

That's what I initially assumed. I have everything populated in there to no luck.

`# the address your emails (save the dates/invites/etc.) will come from DEFAULT_WEDDING_FROM_EMAIL = 'Hannah and Alexander wedding@12345.com' # the default reply-to of your emails DEFAULT_WEDDING_REPLY_EMAIL = 'guests@12345.com'

# when sending test emails it will use this address DEFAULT_WEDDING_TEST_EMAIL = DEFAULT_WEDDING_FROM_EMAIL

# This is used in a few places where the names of the couple are used BRIDE_AND_GROOM = 'Hannah and Alexander'

# This is used in links in save the date / invitations WEDDING_WEBSITE_URL = 'http://12345.com' WEDDING_CC_LIST = [] # put email addresses here if you want to cc someone on all your invitations `

czue commented 5 years ago

Are you sure you edited the right file? That should be all that's required.

If you run:

./manage.py shell
from django.conf import settings
print(settings.WEDDING_WEBSITE_URL)

Do you see your changes?

ataylor-orcsd-org commented 5 years ago

Yes, that works. Some testing: on the home page, the email, etc. is replaced correctly. On the Save the Date pages, it's not.

czue commented 5 years ago

Yes, that works. Some testing: on the home page, the email, etc. is replaced correctly. On the Save the Date pages, it's not.

Ah, thanks for the clarification! Likely an oversight on my part. I'll try to fix as soon as I can (and pull requests are welcome! :smile: )

dillwishlist commented 3 years ago

37 Please review this PR - should be (at least somewhat) improved.

czue commented 3 years ago

@dillwishlist do you think there's more to do here or shall I close this?

dillwishlist commented 3 years ago

@czue I think I it's safe to close, I can't find any other instances of this at the moment.