search

czue / django-wedding-website

A django-powered wedding website and guest-management system
Other
458 stars 273 forks source link

Increased usability for the SMTP backend #49

Closed m-terlinde closed 1 year ago

m-terlinde commented 1 year ago

Hey @czue,

I've tried to increase the usability for people to use a SMTP back end. Also, I've created a template for the localsettings.py.

This should prevent, that users will leak their secrets to a Git repo, because they try to enter their credentials into the settings.py instead of the localsettings.py.

Hope that helps, Matthias

m-terlinde commented 1 year ago

Sure thing, I've edited the readme file.

Reading the text again: do you think I should set DEFAULT_WEDDING_FROM_EMAIL, DEFAULT_WEDDING_REPLY_EMAIL and SECRET_KEY in the localsettings.py as well?

And if this is okay for you, I'd like to move the Wiki entry to the readme as well, because it's hard to find there.

czue commented 1 year ago

do you think I should set DEFAULT_WEDDING_FROM_EMAIL, DEFAULT_WEDDING_REPLY_EMAIL and SECRET_KEY in the localsettings.py as well?

You mean the the template, yeah? I think that would be helpful, yes.

And if this is okay for you, I'd like to move the Wiki entry to the readme as well, because it's hard to find there.

For sure. I think someone asked me to set that up, but I've never used it.

m-terlinde commented 1 year ago

I think I'm done now. Everything should be neat and tidy. Didn't run into errors running it with the console email backend. The output looked valid.

Also migrated the wiki entry to the README.md. Since I'm not a native speaker, please check, if everything is understandable :).

m-terlinde commented 1 year ago

I think now everything is as wanted? :)

One strange thing and I'm not sure, if it has something to do with the refactoring. For the send_invitations command I see, that the text/plain content part doesn't resolve the URL correctly using the test data csv:

grafik

The HTML part seems correct:

grafik

I haven't found the root cause for that so far.

czue commented 1 year ago

For the plaintext email issue, that's an existing bug I never noticed.

I think we need to add site_url here, the same way it is done here

m-terlinde commented 1 year ago

Hey hey, sorry for the typos and the waiting time. I've committed your suggestions thanks to the web UI.

czue commented 1 year ago

great, thanks for the contribution @m-terlinde !