search

czyzby / gdx-lml

:octocat: LibGDX utility libraries.
Apache License 2.0
159 stars 25 forks source link

LibGDX 1.9.10 compatibility. #95

Closed metaphore closed 5 years ago

metaphore commented 5 years ago

I know the library development is down now, but I think current codebase should be carried to the latest LibGDX release. That way people can still update their LML dependent projects and don't be bound to the old LibGDX versions because of the library. So here is my take on refreshing the repo...

I made little required changes to meet LibGDX 1.9.10 compatibility. Besides kiwi and lml modules, I didn't make a lot of testing, but all the modules build without any errors and generally seem to be working.

I hope you don't mind I included Gradle wrapper into repository. I know you intentionally stick to local Gradle distribution, but I think that's something pretty regular for modern open source libraries. If someone would want to work with sources, they most likely will appreciate the wrapper presence, otherwise they always have an option to work with their locally installed Gradle.

Names of the sub-modules were also changed (e.g. autumn/natives/android to autumn:natives:android). That should be better for modern Gradle releases.

Currently lml-vis references vis-ui 1.4.4-SNAPSHOT version, but shall be updated to the upcoming release version.

@czyzby, I'd appreciate if you take a look, possibly merge the changes and make 1.9.1.9.10-SNAPSHOT version available on Maven repo, so the lib gets breezing and keep everyone happy as it always was :)

czyzby commented 5 years ago

Thank you very much for doing the maintenance. I had a quick look at the changes and it seems to be OK, but I'll probably only push a snapshot since a complete release requires tedious manual testing (including GWT). One of the downsides of not having an automatic test suite.

By the way, you can consider maintaining a fork of the libraries - I'll link your repo in the README.

czyzby commented 5 years ago

I'm currently getting Return code is: 503 , ReasonPhrase:Service Temporarily Unavailable. during the upload, but the snapshot release should be available in a few hours. Thanks again.

metaphore commented 5 years ago

@czyzby awesome, thanks! I can see that the snapshot is live now.

By the way, you can consider maintaining a fork of the libraries - I'll link your repo in the README.

That's actually a pretty good idea. I really enjoy having LML in every single LibGDX project since I discovered the library, but the fact that there is no any further development for such a great tool always makes me feel sad. Definitely have some thoughts on how some parts can be evolved next. Please let me sleep on it some time and if once I setup the fork ready to be published, I will let you know.