search

d-Rickyy-b / pastepwn

Python framework to scrape Pastebin pastes and analyze them
MIT License
122 stars 66 forks source link

Use listify for certain analyzers #190

Closed d-Rickyy-b closed 3 years ago

d-Rickyy-b commented 4 years ago

I found that certain analyzers are still using their own "listify" code.

e.g.

https://github.com/d-Rickyy-b/pastepwn/blob/9b2fee22857e54a5312fdb3d388b472a7d271c50/pastepwn/analyzers/wordanalyzer.py#L12-L17

This should not be the case.

colincrawford commented 4 years ago

@d-Rickyy-b should the words param always be of type List (or None)? or is there a different "listify" function you have in mind?

d-Rickyy-b commented 4 years ago

Hi @colinlcrawford, you can use the listify util function in analyzers whenever it should be possible to handle multiple inputs. I think it would be cool to handle multiple inputs e.g. for the whole word analyzer or even others. Feel free to add this feature :)

Thanks in advance.

colincrawford commented 4 years ago

Hey @d-Rickyy-b , I did a scan of the analyzers and it looks like they've all been updated. The wordanalyzer ^ has been updated in dev and I made the update in my PR for the exactwordanalyzer as well

d-Rickyy-b commented 3 years ago

Fixed in https://github.com/d-Rickyy-b/pastepwn/commit/0f60fbace3943752a0b415dd97fabfa807981a56