search

d-a-v / ESPWebDAV

macOS, linux, windows: Natively sharing files - port 80 is shared
Other
41 stars 9 forks source link

Doesn't list filenames with spaces in them #15

Closed idolpx closed 2 years ago

idolpx commented 3 years ago

Need to URL Encode fullResPath in ESPWebDAVCore::sendPropResponse() to correct the issue.

I will do a PR later when I am able if you'd like.

d-a-v commented 3 years ago

I am able to see spaces in file names. Did you by misfortune exceed the file name length capacity ?

idolpx commented 3 years ago

No but after I url encode them it works fine.

d-a-v commented 3 years ago

Did you patch ESPWebDAVCore::sendPropResponse() to url-encode names ?

idolpx commented 3 years ago

Yes... I did. Seemed to fix the issue for me.

d-a-v commented 3 years ago

Can you please share it as a PR ? Is it committed on your fork ?

idolpx commented 3 years ago

I made the changes when adding it to meatloaf project. I will test the additions you made for changing the web root and update my repo and send a pull request then. :)

idolpx commented 3 years ago

Ok... sent a PR. Just a one line fix.

d-a-v commented 2 years ago

closed per #18