search

d-a-v / esp82xx-nonos-linklayer

esp8266 link layer API for new ip stack - applied to lwIP-v2
31 stars 22 forks source link

Thoughts on RTOS_SDK options #38

Open someburner opened 5 years ago

someburner commented 5 years ago

Scanning over the RTOS SDK I saw a couple changes they've made to their lwip. Thoughts on these?

https://github.com/espressif/ESP8266_RTOS_SDK/commit/d64f04bc95845d7de3d8cfbfe885ead1b80f10da

https://github.com/espressif/ESP8266_RTOS_SDK/commit/a183ccc81e34436b10b71b093719e73e338f799a

https://github.com/someburner/esp82xx-nonos-linklayer-opensdk/commit/893a240de8e551935edc40a7b5ca60bd79d89170

last one is on my repo, that's extracted from their kconfig defaults.

There are others too. Just wondering if you think it's worth following their changes for certain lwip things.

d-a-v commented 5 years ago

Yes you can add these here too, or is this a feature request ?

Let me claim also here that espressif is again doing things not the best way with lwIP: Instead of having a patch policy, they integrate their changes in their local copy. Once again they shoot themselves in the foot because it makes lwIP upgrade much more difficult (well, much less than with nonos-sdk though :)

someburner commented 5 years ago

If I can resolve the open-sdk PR for my project I can make these changes and submit another PR.

I agree they really did not think this through at all. Maintaining a set of patches is much cleaner and easier for other developers to follow. Trying to navigate through their source history is painful.

someburner commented 1 year ago

Another one.. scanning over NONOS_SDK commits from last year.. https://github.com/espressif/ESP8266_NONOS_SDK/commit/a9a39bbc9b838de50d60f2448ecee6080bb332e4

I wish there was some sort of description for these regarding the set of circumstances leading them to make these changes.