search

d-bl / GroundForge

Bobbin Lace Diagrams : threads from pairs
https://d-bl.github.io/GroundForge/
GNU General Public License v3.0
12 stars 7 forks source link

add href to images with onClick #190

Closed jo-pol closed 1 year ago

jo-pol commented 3 years ago

problem: https://groups.io/g/GroundForge/topic/81673031 quick fix: https://github.com/d-bl/GroundForge/commit/9bba012e

The current workaround sets the focus to the draggable checkbox. It would be better to set the focus to the clicked image. For that purpose it should become a link with a javascript:... href attribute.

Another issue in this context: why did the "d3.select" call not work from within the onclick event? Would it work from the 'href' attribute?

jo-pol commented 1 year ago

fixed with apply button and dummy button 3c460a57

jo-pol commented 1 year ago

fixed with apply button and dummy button 3c460a57