search

d-date / google-mlkit-swiftpm

Google MLKit for iOS in Swift Package Manager
Apache License 2.0
92 stars 21 forks source link

add Firebase? #11

Closed aelam closed 2 years ago

aelam commented 2 years ago

They share a lot of dependencies, Currently, we are using both Firebase and GoogleMLKit. it would be difficult without Firebase support here

Do you have any ideas?

d-date commented 2 years ago

@aelam Of course considered about Firebase. See https://github.com/d-date/google-mlkit-swiftpm/blob/main/Example/Package/Package.swift

d-date commented 2 years ago

@aelam As you can see my Package.swift, common dependencies are come from SwiftPM. https://github.com/d-date/google-mlkit-swiftpm/blob/main/Package.swift

My article might be helped you (Sorry about written in Japanese) https://zenn.dev/d_date/articles/cd4ce3b2b5c29d

aelam commented 2 years ago

thank you! it looks great thanks for your hard work

BTW maybe change the package name to GoogleMLKit should be OK? without swifpm suffix

d-date commented 2 years ago

@aelam It's OK but have no effect for everywhere. If you want, it's welcome to PR.