search

d-e-s-o / debuginfod

A crate for interacting with debuginfod servers.
Apache License 2.0
3 stars 1 forks source link

Add `Response` struct and return it in `Client::fetch_debug_info()` #10

Closed javierhonduco closed 1 week ago

javierhonduco commented 1 week ago

Which allows for a richer set of informatiomn to be passed to the caller beyond the actual debug information reader. The first additional field is the debuginfod server that returned the response. This is very helpful for systems that want to store the source of said debug information. This is typicall used for later debugging, re-downloading the debug information, if needed, etc.

Test Plan

Adapted the tests.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.72%. Comparing base (c407209) to head (12383cb). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 81.31% 81.72% +0.40% ========================================== Files 4 4 Lines 273 279 +6 ========================================== + Hits 222 228 +6 Misses 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

javierhonduco commented 1 week ago

Thanks for the review, all makes sense!

javierhonduco commented 1 week ago

Closes https://github.com/d-e-s-o/debuginfod/issues/8