search

d-e-s-o / debuginfod

A crate for interacting with debuginfod servers.
Apache License 2.0
3 stars 1 forks source link

Potential async support #3

Open javierhonduco opened 1 week ago

javierhonduco commented 1 week ago

Hi, hi!

Would you consider adding async support to this crate? This is no a deal-breaker for me but I am evaluating this crate in an async environment (using tokio) and this could be a nice addition. I am not sure what's the story like for Rust libraries supporting both sync and async code... Seems a bit messy, and my async Rust skills are not good enough to be able to assess this well.

Currently using this library without spawning tokio::task::block_in_place can cause runtime panics. Currently investigating this, but will update the issue once I understand this a bit better.

d-e-s-o commented 1 week ago

I agree that for this kind of library including async support makes a lot of sense. My main worry, as you said, is that having both sync and async paths tends to be somewhat complex and a trade off on many fronts. But many libraries manage to do it. An article that I read some time back summarizing approaches is https://nullderef.com/blog/rust-async-sync/ Perhaps there are some lessons to be taken away from it.

javierhonduco commented 1 week ago

Cool, thanks for the link, I'll take a look and see if I can wrap my head around the async world 😄