search

d-e-s-o / nitrocli

A command line tool for interacting with Nitrokey devices.
30 stars 10 forks source link

Remove pws set #162

Closed robinkrahl closed 3 years ago

robinkrahl commented 3 years ago

This patch removes the pws set subcommand as part of the PWS interface refactoring, see #139. Users should use pws add (for writing to new slots) or pws update (for writing to existing slots) instead. This makes it less likely to accidentally overwrite PWS data.

d-e-s-o commented 3 years ago

Merged! Thank you Robin! FYI: I removed the pws clear 10 call that I didn't understand why we would need. Let me know if it had some deeper intention that I just didn't grok.

d-e-s-o commented 3 years ago

Oh, and I didn't revert the MSRV bump. I honestly think it's fine to go a bit higher in the supported Rust version, so that we can use newer features over time; and 1.43.0 is already a year old by now. Let me know if there are some requirements to stay at 1.42 for packaging or something like that.