d-iii-s / msim

Light-weight MIPS R4000 and RISC-V system simulator
https://d3s.mff.cuni.cz/software/msim/
GNU General Public License v2.0
5 stars 5 forks source link

RISCV: Rename device commands #59

Closed HanyzPAPU closed 6 months ago

HanyzPAPU commented 10 months ago

The csrrd and tlbrd are named after the rd command, which stands for "register dump". In this way csrrd would read "control and status register register dump" and tlbrd would read "translation look-aside buffer register dump"

I would propose to change these commands to csrd and tlbd. This would also be more consistent wrt. the MIPS commands, where the TLB dump is also named tlbd.

vhotspur commented 10 months ago

I would propose to change these commands to csrd and tlbd.

Agreed. I would just like to do this after the course is over and also do it together with #38 and have csrd and cserd for the extended dump (or something like that).

If you want to work on this, please, feel free to start a draft PR or assign the issue to yourself so that we do not implement it twice :-)

HanyzPAPU commented 10 months ago

Could you please assign me to this issue? It seems cannot do it myself.

I'll create the draft PR when I start working on this issue.