d-koppenhagen / vscode-code-review

Create a code review with all your comments in one file

https://marketplace.visualstudio.com/items?itemName=d-koppenhagen.vscode-code-review

MIT License

68 stars 36 forks source link

[bug] Support multi-root workspace #106

Closed girivs82 closed 3 years ago

girivs82 commented 3 years ago

🐞 Bug report

Description

Currently, code-review.csv is generated in the first root of a multi-root workspace ## Reproduction Simply have more than one root in your workspace, you will notice the code-review.csv will be generated only in the first workspace root. ## Error message

🌍 Your Environment


 
Vscode MacOs running remote ssh to linux

AlexandreMarkus commented 3 years ago

https://code.visualstudio.com/docs/editor/multi-root-workspaces https://github.com/microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs

d-koppenhagen commented 3 years ago

@girivs82 please checkout version 1.26.0 it should support multi-root workspaces now. @AlexandreMarkus thanks for this very helpful links as I didn't had any clue about how to implement it before 😄

girivs82 commented 3 years ago

thanks! I'll take a look today or tomorrow.

AlexandreMarkus commented 3 years ago

@girivs82 please checkout version 1.26.0 it should support multi-root workspaces now. @AlexandreMarkus thanks for this very helpful links as I didn't had any clue about how to implement it before 😄

Thank you, I confirm it is working well with multi-root!!! Great job!!

girivs82 commented 3 years ago

LGTM! Thanks to both @d-koppenhagen and @AlexandreMarkus for quick implementation and support!