d-krupke / skbuild-conan

An extension for scikit-build to add C++-dependencies as easily as Python dependencies via conan.
MIT License
4 stars 2 forks source link

Can't get it running on Windows #4

Closed d-krupke closed 1 year ago

d-krupke commented 1 year ago

I tried to get this running on a Windows machine and GitHub Workflow with Windows image, but it fails. Not sure if it is the general setup or a problem with skbuild_conan. I actually think that the problem may be with MSVC and scikit-build, but I would like how to get it working again. It seemed to be working before packaging the tricks into skbuild_conan.

Racopokemon commented 1 year ago

Adding a certain cmake argument in the project https://github.com/d-krupke/pyvispoly possibly solved an issue with cmake backwards compatibility for MSVC. However, the build still fails on my machine.

cmake_args=["-DCMAKE_POLICY_DEFAULT_CMP0091=NEW"],
d-krupke commented 1 year ago

Working now.