search

d-language-server / dls

A Language Server implementation for D
http://dls.dub.pm
106 stars 15 forks source link

Fix: Deprecation warnings about JSON #57

Closed ghost closed 5 years ago

ghost commented 5 years ago

In the latest dmd, deprecation warnings appear when using JSON_TYPE.

LaurentTreguier commented 5 years ago

Looks good to me. Can you target the release/v0.25.x branch instead of master before the merge ?

EDIT: nevermind, I can actually edit the PR to change this EDIT 2: actually nevermind the first edit; since your fix-warning branch is based on master, this would bring commits from master to release/v0.25.x (which isn't supposed to happen). The reason I'm asking you to make a PR on release/v0.25.x is because I am not actively working on DLS now, so there isn't going to be any new minor release anytime soon, only patches here and there. So if the PR could target release/v0.25.x instead of master, I could easily do a quick patch release with a clean new build.

LaurentTreguier commented 5 years ago

Fixed with https://github.com/d-language-server/dls/commit/55fa50273989e6b86aaf4669fb54186cfcdff8c9 (cherry-picked your commit in release/v0.25.x) and https://github.com/d-language-server/dls/commit/6a350f25cf489e2c5e1888f3cc9f23de1735845c for the usage in the dls:bootstrap submodule; v0.25.15 is on the way