search

d-lowl / chrome-extension-svelte-boilerplate

MIT License
116 stars 18 forks source link

Svelte 3 #1

Closed enricribas closed 5 years ago

enricribas commented 5 years ago

I'm trying to update to Svelte but having some issues. Any plans to update? Thanks for creating this.

d-lowl commented 5 years ago

I had no plans essentially, but I can look into it next week (when I am less busy). Any specific issues with Svelte 3 you want me to look into?

enricribas commented 5 years ago

That would be awesome. I managed to get npm run build to work but can't seem to get the hotloading to work with chrome extension.

d-lowl commented 5 years ago

Upgraded to Svelte 3 + some other packages for compatibility. Now it should work just fine (tested it in Brave)

d-lowl commented 5 years ago

@enricribas pinging the OP, in case there was no notification

enricribas commented 5 years ago

Not sure if I'm doing something wrong or it's the webpack setup but I narrowed down the issue that I was having and am still seeing it with your changes. When I use a nested component, and npm run build and install the extension locally, it works. However using npm run start, I get a blank popup in the extension when I load from the build directory. npm run start works as long as I don't use nested components. Any ideas? Thanks.

enricribas commented 5 years ago

@d-lowl Not going to re-open but if you have any insights into the above, I'd appreciate it.

NasirKhalid24 commented 5 years ago

Currently facing the same issue as mentioned by @enricribas, if the little white box is right clicked you can open up the console for it through 'inspect element'. The error that it gives is attached

Screen Shot 2019-07-18 at 2 15 20 PM