search

d-m-bailey / extra_be_checks

Extra backend checks for sky130
Apache License 2.0
6 stars 3 forks source link

Mpw 7 #22

Closed marwaneltoukhy closed 1 year ago

marwaneltoukhy commented 2 years ago
d-m-bailey commented 2 years ago

Thanks for the suggestions.

@marwaneltoukhy flatglob, abstract, flatten, and noflatten may be different for different blocks, so we may not want to use $LVS_ROOT for those. Maybe copy the default version from $LVS_ROOT with a warning if the file does not exist in the current directory.

Is it ok to keep the extract directory in the current directory or would you like a override for that too (ie. WORK_DIR)?

marwaneltoukhy commented 2 years ago

@marwaneltoukhy flatglob, abstract, flatten, and noflatten may be different for different blocks, so we may not want to use $LVS_ROOT for those. Maybe copy the default version from $LVS_ROOT with a warning if the file does not exist in the current directory.

I don't really understand this part, $LVS_ROOT should basically be the path to this repo in the file system. Maybe the name of the variable isn't straight forward, we can change it to $BE_CHECKS_ROOT for example.

Also, I was trying to think of a more automatic way of writing the flatglob, abstract, flatten, and noflatten is that possible or are we going to have to rewrite it every time we do LVS for a different block?

I don't mind the extract directory staying at the same place, but we can add a global variable for it as well so that in the future if we want to change it, it would be easy

d-m-bailey commented 2 years ago

I don't really understand this part, $LVS_ROOT should basically be the path to this repo in the file system. Maybe the name of the variable isn't straight forward, we can change it to $BE_CHECKS_ROOT for example.

$LVS_ROOT is fine. It's just that flatglob, abstract, flatten, and noflatten aren't necessarily the same for every block or process.

Also, I was trying to think of a more automatic way of writing the flatglob, abstract, flatten, and noflatten is that possible or are we going to have to rewrite it every time we do LVS for a different block?

I think we should give the users a default and let them modify as needed.

d-m-bailey commented 1 year ago

@marwaneltoukhy I incorporated most of these suggestions in another branch, so I'm going to close this.